Move htex interchange tasks incoming thread into main thread #3752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
performance notes: parsl-perf -t 30, my laptop, no logging before this PR, 2320 post this PR, 2344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes one of two non-main threads in the interchange - the task puller thread - and moves the behaviour there (receive a message and put it in an in-process queue) into the main thread (where that in-process queue is ultimately dequeued, anyway)
This is aimed at helping with ZMQ-vs-threads issues within the interchange -- most immediately, clean shutdown #3697
performance notes:
parsl-perf -t 30, my laptop, no logging
before this PR, 2320 tasks/second
post this PR, 2344 tasks/second
cc @rjmello who expressed especial interest in this
Changed Behaviour
Some performance difference, although the brief measurements above are not concerning.
Type of change